Pr/reasoning logging#21
Merged
raghavm243512 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
| "latency": llm_stats.get("latency", 0.0), | ||
| "parameters": json.dumps(llm_stats.get("parameters", {})), | ||
| "tool_calls": json.dumps(response_tool_calls_for_stats) if response_tool_calls_for_stats else "", | ||
| "reasoning": f'"{llm_stats.get("reasoning_content", "")}"', |
Collaborator
There was a problem hiding this comment.
is there are a reason we're doing the formatted string here?
Collaborator
Author
There was a problem hiding this comment.
Yea, the content is put into the csv file with no delimiters around the string, so if you tried to parse the csv with something and the agent used a comma, it would break
tara-servicenow
approved these changes
Mar 26, 2026
Update system.py reasoning tokens and quoting Revert "reasoning tokens and quoting" This reverts commit a20dee9. quoting Apply pre-commit
raghavm243512
force-pushed
the
pr/reasoning_logging
branch
from
b6b08ff to
0a99102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log reasoning in agent perf stats and Audit log